Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block out landing page elements #375

Merged
merged 10 commits into from
Nov 12, 2023
Merged

Conversation

ArendPeter
Copy link
Member

Description

I copied the landing page elements from figma: https://www.figma.com/file/Z6HA3YZz56bwjwYihmJ1Mv/STAR-Mock-Ups-W-MUI?type=design&node-id=6472-77151&mode=design&t=dKOeio58jJfkLJpg-0

Screenshots / Videos (frontend only)

2023-10-20.19-28-20.mp4

The responsiveness is 90% working, but there's a sliver that appears on the 320px view that I'm having trouble figuring out

Related Issues

@ArendPeter ArendPeter requested a review from mikefranze October 21, 2023 02:33
@mikefranze
Copy link
Collaborator

For the sliver of white on the side, most likely one of the components is having its width or min width set manually to something larger than 320. You might be able to inspect the elements to see which one is poking out.

import React from 'react';

export default ({electionId}) => {
return <Paper className='featuredElection' elevation={8} sx={{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try out the Material UI card component for these. It uses the paper component but with extra features.
https://mui.com/material-ui/react-card/

@ArendPeter
Copy link
Member Author

For the sliver of white on the side, most likely one of the components is having its width or min width set manually to something larger than 320. You might be able to inspect the elements to see which one is poking out.

Yep it was the trashcan icon. The quick poll component was adding extra padding that was making everything a tad too wide

I also switch Paper over to Card

@ArendPeter ArendPeter merged commit 9f66f05 into Equal-Vote:main Nov 12, 2023
3 checks passed
@ArendPeter ArendPeter deleted the front-page branch December 9, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants