Adding Typescript version of STAR-PR with tests #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArendPeter
reviewed
May 31, 2023
| expect(results.summaryData.weightedScoresByRound[1]).toStrictEqual([0, 0, 16, 23]); | ||
| }) | ||
| test("Fractional surplus", () => { | ||
| // Two winners, two main parties, Allison wins first round with highest score, Allison has 8 highest level supporters, more than the quota of 6 voters |
There was a problem hiding this comment.
What if Allison's highest level supporters has 4 5s and 4 4s? Does the fractional surplus work any differently? If so, can we add another test?
There was a problem hiding this comment.
Good question, it is handled slightly different. Added extra test case.
| } | ||
| } | ||
| // converts list of strings to string with correct grammar ([a,b,c] => 'a, b, and c') | ||
| const formatter = new Intl.ListFormat('en', { style: 'long', type: 'conjunction' }); |
There was a problem hiding this comment.
Is this variable used? The logic seems like a front end problem, so I was surprised to see it here
There was a problem hiding this comment.
It was accidently copied over from the STAR tabulator which uses it to write human readable logs. It could possibly be used in all the tabulators but removed it for now.
ArendPeter
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating STAR-PR (Allocated Score) to typescript with a few basic tests.
Currently the random tiebreaker works, but there are some cases where numerical errors can prevent ties from being found (Equal-Vote/starpy#23). This isn't a huge deal at the moment since the ties will be broken randomly and the numerical errors are probably random, but it'll be best to be able to at least identify ties.
I suspect it is related to or exacerbated by the scores normalization, so removing that will be the first step.