convert targeting_rules_experiment to have semver version #9
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
force-pushed
the
lr/ff-1433/semver
branch
from
1f8d522
to
e96b18d
Compare
sameerank
reviewed
Feb 6, 2024
| @@ -177,7 +177,7 @@ | |||
| "attribute": "device" | |||
| }, | |||
| { | |||
| "value": 1, | |||
| "value": "1.2.3", | |||
There was a problem hiding this comment.
Ideally, this update also is in rac-experiments-v3-obfuscated.json and rac-experiments-v3-hashed-keys.json
Or you could make a separate test case file for the JS sdk and update its test run script to use it so that it only runs there. I think the automated testing is set up to assume this would work in all SDKs, which I have a feeling it won't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.