Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [import apiendpoints and expose url builder] (ff-2310) #85

Merged

Conversation

sameerank
Copy link
Contributor

@sameerank sameerank commented Jun 21, 2024

Fixes: #issue

Motivation and Context

Description

Exposes a URL builder for the flag config endpoint

Also FYI there are a lot of auto-generated docs that I didn't include in this PR because I noticed that these docs weren't getting updated in the last few PRs, but I can include those files if it's the right thing to do here.

How has this been tested?

@sameerank sameerank changed the title [feat] import apiendpoints and expose url builder (ff-2310) feat: [import apiendpoints and expose url builder] (ff-2310) Jun 21, 2024
@@ -59,6 +59,6 @@
"webpack-cli": "^4.10.0"
},
"dependencies": {
"@eppo/js-client-sdk-common": "3.3.1"
"@eppo/js-client-sdk-common": "3.3.3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@leoromanovsky leoromanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Member

@felipecsl felipecsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sameerank sameerank merged commit d52c661 into main Jun 21, 2024
2 checks passed
@sameerank sameerank deleted the sameeran/ff-2310-import-apiendpoints-and-expose-url-builder branch June 21, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants