Adds LocalStorageAssignmentCache with persistent implementation between sessions to lower assignment logging; enabled by default (FF-839) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en sessions to lower assignment logging; enabled by default (FF-839)
leoromanovsky
commented
Dec 18, 2023
| @@ -57,8 +57,8 @@ | |||
| "xhr-mock": "^2.5.1" | |||
| }, | |||
| "dependencies": { | |||
| "@eppo/js-client-sdk-common": "^1.7.0", | |||
| "axios": "^0.27.2", | |||
| "@eppo/js-client-sdk-common": "2.0.0", | |||
| "@eppo/js-client-sdk-common": "^1.7.0", | ||
| "axios": "^0.27.2", | ||
| "@eppo/js-client-sdk-common": "2.0.0", | ||
| "axios": "^1.6.0", |
There was a problem hiding this comment.
Needed to upgrade axios to match the major version in the commons sdk otherwise would not compile
| @@ -256,6 +257,36 @@ describe('EppoJSClient E2E test', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('LocalStorageAssignmentCache', () => { | |||
There was a problem hiding this comment.
testing the cache directly instead of as an integration with getAssignment as those already existing in the commons
|
|
||
| public has(key: string): boolean { | ||
| if (!hasWindowLocalStorage()) { | ||
| return false; |
There was a problem hiding this comment.
Thought about throwing an error here however there's nothing with people disabling this API and functionally the SDK should continue to work.
There was a problem hiding this comment.
Makes sense to me too. No error throwing here 👍
sameerank
approved these changes
Dec 20, 2023
aarsilv
approved these changes
Dec 20, 2023
| @@ -256,6 +257,36 @@ describe('EppoJSClient E2E test', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('LocalStorageAssignmentCache', () => { | |||
| try { | ||
| return typeof window !== 'undefined' && !!window.localStorage; | ||
| } catch { | ||
| // Chrome throws an error if local storage is disabled and you try to access it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels: mergeable
Fixes: #issue
Motivation and Context
Downstream related change: Eppo-exp/js-client-sdk-common#33 enables passing an implementation.
The goal is for users of Eppo's SDK in the browser to remove duplicate assignments within and now between sessions.
We are creating a cache based on
LocalStoragewhich is a unique API to browsers.Description
LocalStoragekey for the entire assignment cache - it is always for a single subject.How has this been tested?