feat: Initial Configuration #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typotter
force-pushed
the
tp/common-latest
branch
from
d8a38fa
to
1d4dca4
Compare
typotter
force-pushed
the
tp/common-latest
branch
from
1d4dca4
to
3ef59d0
Compare
typotter
commented
Sep 25, 2024
| @@ -31,7 +31,7 @@ repositories { | |||
|
|
|||
| dependencies { | |||
| // Re-export classes and interfaces that will be used upstream | |||
| api 'cloud.eppo:sdk-common-jvm:3.0.2' | |||
| api 'cloud.eppo:sdk-common-jvm:3.2.0-SNAPSHOT' | |||
There was a problem hiding this comment.
Using snapshot until release is cut/pushed
typotter
commented
Sep 25, 2024
| @@ -276,7 +276,7 @@ private void uninitClient() { | |||
| private void initBuggyClient() { | |||
| try { | |||
| EppoClient eppoClient = initClient(DUMMY_FLAG_API_KEY); | |||
| Field configurationStoreField = BaseEppoClient.class.getDeclaredField("requestor"); | |||
| Field configurationStoreField = BaseEppoClient.class.getDeclaredField("configurationStore"); | |||
There was a problem hiding this comment.
base implementation changed to access config only through the store.
typotter
changed the title
felipecsl
approved these changes
Sep 25, 2024
aarsilv
approved these changes
Sep 26, 2024
| @@ -125,6 +139,12 @@ public Builder host(String host) { | |||
| return this; | |||
| } | |||
|
|
|||
| /** Sets the initial configuration for the client. */ | |||
| public Builder initialConfiguration(CompletableFuture<Configuration> initialConfiguration) { | |||
|
Obviously don't merge & release until common is published and tests pass here 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up latest from common package.