Reading test data files from github repo instead of cloud storage #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agamkrbit
commented
Aug 29, 2023
Comment on lines
+40
to
+46
| mkdir -p $(tempDir) | ||
| cd ${tempDir} \ | ||
| && git clone -b ${branchName} --depth 1 --single-branch ${githubRepoLink} \ | ||
| && rm -rf RepoName/.git/ | ||
| cp ${gitDataDir}/rac-experiments-v3.json ${testDataDir} | ||
| cp -r ${gitDataDir}/assignment-v2 ${testDataDir} | ||
| rm -rf ${tempDir} |
There was a problem hiding this comment.
First I am cloning the git repo into a temp folder and then copying only those files which are required for the testing. This gives some freedom to the dependent repo to only pull those files which are required.
leoromanovsky
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some change in the way we are pulling the test data. Earlier we were pulling the test data from gcp cloud storage. Now I am pulling the test data from a github repository.