Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Gson dependency #59

Merged
merged 5 commits into from
Jun 11, 2024
Merged

chore: Remove Gson dependency #59

merged 5 commits into from
Jun 11, 2024

Conversation

felipecsl
Copy link
Member

@felipecsl felipecsl commented Jun 11, 2024

Description

This is a breaking change, as it changes the public signature of EppoClient#getJSONAssignment, so we should bump the major version to v4.0.0 to reflect that.

This depends on Eppo-exp/sdk-common-jdk#7

Summary of changes

  • Removed dependency on Gson
  • Replaced parsing with Jackson instead, which was also already a dependency
  • Fixed tests
  • Made some classes immutable

@felipecsl felipecsl enabled auto-merge (squash) June 11, 2024 22:08
Copy link
Contributor

@aarsilv aarsilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digging the immutable DTOs! This is awesome same minor questions as the other: should we be using org.json so Android builds don't need an extra package?

@felipecsl felipecsl merged commit 018bbbf into main Jun 11, 2024
1 check passed
@felipecsl felipecsl deleted the felipecsl--remove-gson branch June 11, 2024 23:17
@felipecsl
Copy link
Member Author

Digging the immutable DTOs! This is awesome same minor questions as the other: should we be using org.json so Android builds don't need an extra package?

Synced offline, TL;DR yes we're exposing org.json.JSONObject here https://github.com/Eppo-exp/android-sdk/blob/main/eppo/src/main/java/cloud/eppo/android/EppoClient.java#L353-L355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants