Allow to spawn workers inside daemon #1067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bouthilx
reviewed
Jan 19, 2023
bouthilx
reviewed
Jan 19, 2023
bouthilx
reviewed
Jan 19, 2023
added 3 commits
January 20, 2023 12:36
bouthilx
reviewed
Feb 6, 2023
| return i | ||
|
|
||
|
|
||
| def has_pytorch(): |
bouthilx
reviewed
Feb 6, 2023
| self.pool_config = state["pool_config"] | ||
| backend = self.pool_config.get("backend") | ||
| n_workers = self.pool_config.get("n_workers", -1) | ||
| self.pool = PoolExecutor.BACKENDS.get(backend, ThreadPool)(n_workers) |
There was a problem hiding this comment.
I'm a bit unsure about this part. If the object is serialized and passed to the subprocess, the deserialization step will have the effect or creating another pool of n_workers, no?
There was a problem hiding this comment.
we maybe able to pass a queue instead to avoid creating multiple pools
but nesting the executor in general is a bit of a nono
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.