Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket subprotocol support #521

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Websocket subprotocol support #521

merged 3 commits into from
Mar 4, 2025

Conversation

mcottontensor
Copy link
Collaborator

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

#404
We would like to be able to provide websocket protocols to the websocket creation.

Solution

Added a configuration parameter that allows the user to specify the protocols to the websocket creation.

Documentation

Updated the typedocs

@mcottontensor mcottontensor marked this pull request as ready for review March 4, 2025 01:05
lukehb
lukehb reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments and one question - just wanted to ensure we are being as safe as we can be with any changes here.

@mcottontensor mcottontensor added auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5 labels Mar 4, 2025
@mcottontensor mcottontensor merged commit 4c78dc8 into EpicGamesExt:master Mar 4, 2025
10 checks passed
@mcottontensor mcottontensor deleted the websocket_protocols branch March 4, 2025 03:54
@github-actions github-actions bot mentioned this pull request Mar 4, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

💚 All backports created successfully

Status Branch Result
✅ UE5.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mcottontensor added a commit that referenced this pull request Mar 4, 2025
@mcottontensor
Merge pull request #527 from EpicGamesExt/backport/UE5.5/pr-521
9d901f2 
[UE5.5] Merge pull request #521 from mcottontensor/websocket_protocols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehb lukehb lukehb approved these changes

Assignees
No one assigned
Labels
auto-backport Used to specify we want a PR to auto backport to a branch, must be paired with auto-backport-to-UEX. auto-backport-to-UE5.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcottontensor @lukehb