Fix edit text button not showing and warnings on desktop #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belchy06
added
auto-backport
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mcottontensor
added a commit
that referenced
this pull request
Mar 3, 2025
[UE5.5] Merge pull request #520 from Belchy06/temp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Edit Textbutton wasn't showing on mobile. Additionally, updates to UE mean that theshowOnScreenKeyboardevent can be sent when on desktop leading to errors about a nulleditTextButtonas that is only created on mobile.Solution
Set correct display type for
Edit Textbutton and add an additional check to check the validity ofEdit Textbutton before trying to do anything with it.Test Plan and Compatibility
Tested on iOS and Win11 with Editor Streaming to verify functionality and no warnings.