Fixing the backspace code thats sent to UE #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcottontensor
added
auto-backport
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mcottontensor
added a commit
that referenced
this pull request
Mar 3, 2025
[UE5.5] Merge pull request #518 from mcottontensor/backspace_fix
|
@mcottontensor Can I request a new version of the 5.5 frontend library be cut to include this change also, so downstream users can update to the newest frontend lib? |
|
Thanks a lot guys ! We will be waitting for the new version. |
|
Pushed a new frontend library version today. 1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Backspace was not working for widget input.
Solution
There's a fair amount of deprecated code in the input system that is what I think lead to this issue, but we have a special case for backspace so it gets sent to UE, only we weren't filling in the correct properties on the KeyboardEvent before sending it and so the event was never handled. I've now added the correct properties.
I've also done a small amount of cleanup and added some comments explaining a few things.