Fix: Git bash failing to run platform scripts on Windows due to tar conflict #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led with Git bash
lukehb
added
auto-backport
mcottontensor
requested changes
Feb 25, 2025
| @@ -206,7 +206,7 @@ if exist coturn\ ( | |||
| curl -L -o ./turnserver.zip "https://github.com/EpicGamesExt/PixelStreamingInfrastructure/releases/download/v4.5.2-coturn-windows/turnserver.zip" | |||
|
|
|||
| @Rem Unarchive the .zip to a directory called "turnserver" | |||
| mkdir coturn & tar -xf turnserver.zip -C coturn | |||
| mkdir coturn & %SystemRoot%\System32\tar.exe -xf turnserver.zip -C coturn | |||
There was a problem hiding this comment.
Would prefer if the path was a variable. ie
set TAR="%SystemRoot%\System32\tar.exe"
up near where NPM is defined. Then just use %TAR%
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mcottontensor
added a commit
that referenced
this pull request
Feb 26, 2025
[UE5.5] Merge pull request #509 from EpicGamesExt/RTCP-8168
|
Will probably need separate changes for older branches than 5.5 since the scripts changed significantly. |
It is okay, we'll leave those older branches as they are then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Some users want to use Git bash on Windows to run the
platform_scripts/cmd.This currently fails as Git bash ships its own (gnu)
tarwhich does not support.zipfiles.Our intent is to use (bsd)
tarthat ships with Windows.Closes #473
Solution
The solution is to explicitly call (bsd) tar which resides in
System32Documentation
N/A
Test Plan and Compatibility
Tested with Git bash and cmd.exe both now work.