Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing browser send offer support. #212

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Removing browser send offer support. #212

merged 9 commits into from
Jul 29, 2024

Conversation

mcottontensor
Copy link
Collaborator

@mcottontensor mcottontensor commented Jul 25, 2024 •
edited
Loading

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Removing the browser send offer support as requested in #164

@mcottontensor mcottontensor marked this pull request as ready for review July 29, 2024 03:35
@mcottontensor mcottontensor requested a review from lukehb July 29, 2024 03:35
lukehb
lukehb requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also requires a docs update here:

https://github.com/EpicGamesExt/PixelStreamingInfrastructure/blob/master/Common/docs/messages.md#playerconnected

https://github.com/EpicGamesExt/PixelStreamingInfrastructure/blob/master/Common/docs/messages.md#answer

@lukehb
Copy link
Contributor

lukehb commented Jul 29, 2024 •
edited
Loading

I guess given this is a breaking protocol change, we should also bump signalling protocol version

Edit: Remove example of updating protocol, that was entirely the wrong spot.

@mcottontensor mcottontensor merged commit ea3f282 into EpicGamesExt:master Jul 29, 2024
3 checks passed
@mcottontensor mcottontensor deleted the remove_sendoffer branch July 29, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehb lukehb lukehb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcottontensor @lukehb