Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The URL parameters should now be case insensitive in the frontend. #199

Merged
merged 1 commit into from
Jul 17, 2024
Merged

The URL parameters should now be case insensitive in the frontend. #199

merged 1 commit into from
Jul 17, 2024

Conversation

mcottontensor
Copy link
Collaborator

Relevant components:

  • Signalling server
  • Common library
  • Frontend library
  • Frontend UI library
  • Matchmaker
  • Platform scripts
  • SFU

Problem statement:

The URL parameters are case sensitive.

Solution

We now handle the URL parameters in a case insensitive way.

Fixes #12

lukehb
lukehb approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@lukehb lukehb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mcottontensor mcottontensor marked this pull request as ready for review July 17, 2024 02:54
@mcottontensor mcottontensor merged commit 8cbfa90 into EpicGamesExt:master Jul 17, 2024
1 check passed
@mcottontensor mcottontensor deleted the url_params_case branch July 17, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehb lukehb lukehb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend settings in URL are case sensitive
2 participants
@mcottontensor @lukehb