Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
lukehb authored Feb 7, 2025
1 parent 701c265 commit e00a2e5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/healthcheck-streaming.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ jobs:
- name: Wait for signalling to come up
run: curl --retry 10 --retry-delay 20 --retry-connrefused http://localhost:999/api/status

- name: Wait for front end to come up
run: curl --retry 10 --retry-delay 20 --retry-connrefused http://localhost:999/

- name: Wait for streamer to come up
run: curl --retry 10 --retry-delay 20 --retry-connrefused http://localhost:999/api/streamers/DefaultStreamer
Expand Down
5 changes: 0 additions & 5 deletions Extras/FrontendTests/tests/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ export function delay(time: number) {
});
}

export async function startStreaming(page: Page) {
await page.evaluate(()=> {
window.pixelStreaming.connect();
});
}

export async function startAndWaitForVideo(page: Page) {
await page.evaluate(()=> {
Expand Down
4 changes: 2 additions & 2 deletions Frontend/implementations/typescript/tsconfig.esm.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"extends": "./tsconfig.base.json",
"compilerOptions": {
"outDir": "./dist/esm",
"module": "ES6",
"moduleResolution": "nodenext"
"module": "es6",
"moduleResolution": "bundler"
}
}

0 comments on commit e00a2e5

Please sign in to comment.