Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Auth #99

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 10, 2013

It is improved version of module emysql_auth + coverage tests. Emysql_auth adapted for the MySQL 3.23-4.1

@jlouis
Copy link
Collaborator

jlouis commented Sep 13, 2013

What is the lure of supporting an old version of MySQL on the main master branch? While I recognize there are people who need support, I am much more inclined to say that it is better to keep this separate from the main repository.

Please educate me: Is there anyone using such an old version, and why are they doing so?

@ghost
Copy link
Author

ghost commented Sep 13, 2013

MySQL 4.0.27 is used in the hosting company (mtw.ru) where I work for some our clients. They use websites that are not adapdted to the Mysql 4.1+. It sounds unbelievable, but true. I want to work with some databases on such servers. I understand that now rare to find a similar problem, but do not exclude the possibility.

There are other advantages in these patch:

@jlouis
Copy link
Collaborator

jlouis commented Sep 16, 2013

I'll look at this when I next integrate patches. I tend to batch them up. I'll probably take a look around the 20th or so.

@jlouis
Copy link
Collaborator

jlouis commented Sep 25, 2013

I have not forgotten this patch, but I'll do it in the next batch when #102 comes back as well :)

@jlouis
Copy link
Collaborator

jlouis commented Feb 24, 2014

Does this still have support? I'll get it in if possible, but I really really really want to rewrite a lot of the code, which means if it can be pushed to "later" it would be much better.

@maxim-komar
Copy link

Ok, lets write my code after your changes.

@jlouis
Copy link
Collaborator

jlouis commented Feb 27, 2014

I went over emysql_auth this evening. I should probably work on tcp or conn next.

@jlouis jlouis added the Enhance label Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants