Fixed build to work with R14,R15,R16,17 and 18 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 29, 2015 10:22
- Added Erlang version check and correct type selection - Added erlang:timestamp() check script and correct compilation path for rebar and Makefile - Added macro for TIMESTAMP and replaced direct calls with macros
|
Good job! I propose a change to move the conditional compilation into the .erl files to avoid issues in projects that include the emysql header. See my patch: howleysv/Emysql@dda35e1 |
added 2 commits
August 26, 2015 21:53
Moved conditional compilation into .erl files to avoid issues in projects that include emysql header.
Builds failed on Erlang prior to 17
|
@howleysv : Proposed patch breaks compilation on pre-17 Erlang versions. |
|
Sorry, I should have tested this myself! I forgot that the built-in types could not be redefined in <17. Renaming to t_type as before seems to work (tested in 18.0 and R16B03-1): |
Included patches: - howleysv@dda35e1 - howleysv@00d2f86
|
@howleysv, it's patched. Everything seems fine now. |
daha
added a commit
to daha/Emysql
that referenced
this pull request
Oct 23, 2015
Merging pull request 172 "Fixed build to work with R14,R15,R16,17 and 18": Eonblast#172
|
Why wouldn't you accept and apply this pull-request? Is something wrong with it or this repository is abandoned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed build scripts and code so it works with latest Erlang/OPT releases.