Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fun "emysql:as_maps/1" #155

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ before_script:

script: "make test"
otp_release:
- 17.0-rc1
- 17.3
- 17.1
- 17.0
- R16B03-1
- R16B
- R15B03
Expand Down
7 changes: 2 additions & 5 deletions rebar.config
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
% -*- Erlang -*-
% vim: ts=4 sw=4 et ft=erlang
{erl_opts, [
nowarn_deprecated_type
]}.
{pre_hooks,[
{"linux|bsd|darwin|solaris", compile, "escript ./support/crypto_compat.escript"},
{"win32", compile, "escript.exe support/crypto_compat.escript"}
nowarn_deprecated_type,
{platform_define, "^[0-9]+", maps_available}
]}.
16 changes: 13 additions & 3 deletions src/emysql.erl
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,15 @@
as_record/4
]).

-ifdef(maps_available).
-export([as_maps/1]).
-endif.

%% Result Data API - Handle results from Mysql
-export([
affected_rows/1,
result_type/1,
field_names/1,
affected_rows/1,
result_type/1,
field_names/1,
insert_id/1
]).

Expand Down Expand Up @@ -692,6 +696,12 @@ as_json(Res) -> emysql_conv:as_json(Res).
PropRow :: proplists:proplist().
as_proplist(Res) -> emysql_conv:as_proplist(Res).

-ifdef(maps_available).
%% @doc package row data as erlang maps
as_maps(Res) -> emysql_conv:as_maps(Res).
-endif.


%% @equiv as_record(Res, Recname, Fields, fun(A) -> A end)
as_record(Res, Recname, Fields) -> emysql_conv:as_record(Res, Recname, Fields).

Expand Down
15 changes: 15 additions & 0 deletions src/emysql_conv.erl
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
as_record/4
]).

-ifdef(maps_available).
-export([as_maps/1]).
-endif.

%% @see emysql:as_dict/1
as_dict(Res = #result_packet{}) ->
dict:from_list(lists:flatten(as_proplist(Res))).
Expand Down Expand Up @@ -78,3 +82,14 @@ json_val({datetime,{ {Year,Month,Day}, {Hour,Min,Sec} }}) ->
[Year, Month, Day, Hour, Min, Sec]));
json_val(Value) ->
Value.

-ifdef(maps_available).
%% @see emysql:as_maps/1
as_maps(#result_packet { rows = Rows } = Result) ->
Fields = emysql:field_names(Result),
[begin
maps:from_list([{binary_to_atom(K, utf8), V} ||
{K, V} <- lists:zip(Fields, Row)])
end || Row <- Rows].
-endif.

14 changes: 12 additions & 2 deletions src/emysql_util.erl
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@
as_record/4
]).

-ifdef(maps_available).
-export([as_maps/1]).
-endif.

affected_rows(P) -> emysql:affected_rows(P).
field_names(R) -> emysql:field_names(R).
insert_id(P) -> emysql:insert_id(P).
Expand All @@ -52,6 +56,12 @@ result_type(R) -> emysql:result_type(R).
as_dict(Res) -> emysql:as_dict(Res).
as_json(Res) -> emysql:as_json(Res).
as_proplist(Res) -> emysql:as_proplist(Res).
as_record(Res, RecName, Fields) -> emysql:as_record(Res, RecName, Fields).
as_record(Res, RecName, Fields, Fun) -> emysql:as_record(Res, RecName, Fields, Fun).

-ifdef(maps_available).
as_maps(Res) -> emysql:as_maps(Res).
-endif.

as_record(Res, RecName, Fields) ->
emysql:as_record(Res, RecName, Fields).
as_record(Res, RecName, Fields, Fun) ->
emysql:as_record(Res, RecName, Fields, Fun).
41 changes: 41 additions & 0 deletions test/basics_SUITE.erl
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ all() ->
emit_warnings,
{group, conversion}].

-ifdef(maps_available).
groups() ->
[{conversion, [parallel],
[dict_empty_test,
Expand All @@ -66,11 +67,31 @@ groups() ->
proplist_empty_test,
proplist_single_test,
proplist_multi_test,
maps_empty_test,
maps_single_test,
maps_multi_test,
json_empty_test,
json_single_test,
json_multi_test,
record_test]}
].
-else.
groups() ->
[{conversion, [parallel],
[dict_empty_test,
dict_single_test,
dict_multi_test,
proplist_empty_test,
proplist_single_test,
proplist_multi_test,
json_empty_test,
json_single_test,
json_multi_test,
record_test]}
].
-endif.



%% Optional suite pre test initialization
%%--------------------------------------------------------------------
Expand Down Expand Up @@ -449,6 +470,25 @@ proplist_multi_test(_) ->
Expect = emysql:as_proplist(get_multi_test()),
ok.

-ifdef(maps_available).
maps_empty_test(_) ->
[] = emysql_util:as_maps(get_empty_test()),
[] = emysql:as_maps(get_empty_test()),
ok.

maps_single_test(_) ->
Expect = [#{'HelloField' => <<"Hello">>}],
Expect = emysql_util:as_maps(get_single_test()),
Expect = emysql:as_maps(get_single_test()),
ok.

maps_multi_test(_) ->
Expect = [#{'ByeField' => <<"Bye">>, 'HelloField' => <<"Hello">>, 'HiField' => <<"Hi">>}],
Expect = emysql_util:as_maps(get_multi_test()),
Expect = emysql:as_maps(get_multi_test()),
ok.
-endif.

json_empty_test(_) ->
[] = emysql_util:as_json(get_empty_test()),
[] = emysql:as_json(get_empty_test()),
Expand Down Expand Up @@ -482,6 +522,7 @@ record_test(_Config) ->
ok.



%%% Data generation
%% --------------------------------------------------------------------------------------------
fields() ->
Expand Down