-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fun "emysql:as_maps/1" #155
base: master
Are you sure you want to change the base?
Conversation
The Travis Ci build's error because maps are not support in R16 |
Maybe it's better to enable this function only for OTP >= 17 for compatibility? |
How to enable this function only for 17? |
Could you have a look at this pull request?? |
@dcy, You can use something like {platform_define, "^[0-9]+", maps_available} in rebar.config and -ifdef(maps_available).
-export([as_maps/1]).
-endif. in code. |
"-ifdef(maps_available)." works in emysql.erl And what's the problem with The Travis CI: |
Try to change - 17.0-rc1 to - 17.3
- 17.1
- 17.0 |
Hi!
I added the fun "emysql:as_maps/1".
And the test result:
21 basics_SUITE conversion maps_empty_test < > 0.000s Ok
22 basics_SUITE conversion maps_single_test < > 0.000s Ok
23 basics_SUITE conversion maps_multi_test < > 0.000s Ok