Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type property #92

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Add type property #92

merged 2 commits into from
Jan 26, 2024

Conversation

matthyk
Copy link
Contributor

@matthyk matthyk commented Jan 19, 2024

Would close #62

This is only the first draft and I still need to add test cases, but are you open to review the PR? @Eomm

Eomm
Eomm reviewed Jan 19, 2024
View reviewed changes
Copy link
Owner

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be a good addition!

@matthyk matthyk requested a review from Eomm January 21, 2024 12:19
@matthyk
Copy link
Contributor Author

matthyk commented Jan 21, 2024

@Eomm What do you think about the following:
If the type of the decorated value is object, then the object may contain properties. It might be useful to return these property names and types as well.

Eomm
Eomm approved these changes Jan 26, 2024
View reviewed changes
Copy link
Owner

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the type of the decorated value is object, then the object may contain properties. It might be useful to return these property names and types as well.

Right now I would not do it - maybe we can discuss it on an issue first.

@Eomm Eomm merged commit caab0a1 into Eomm:main Jan 26, 2024
19 checks passed
This was referenced Jan 30, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typeof decorator
2 participants
@matthyk @Eomm