Skip to content

[CI] Use debug build for x86_64 macOS jobs #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 10 additions & 49 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,54 +30,24 @@ concurrency:

jobs:
test:
timeout-minutes: 90
# timeout-minutes: 90
name: Julia ${{ matrix.version }} - ${{ matrix.test_group }} - ${{ matrix.os }} - assertions=${{ matrix.assertions }} - ${{ github.event_name }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
version:
- '1.10'
# - '1.10'
- '1.11'
# - 'nightly'
os:
- ubuntu-24.04
# `ubuntu-22.04-arm` is considered more stable than `ubuntu-24.04-arm`:
# <https://github.com/orgs/community/discussions/148648#discussioncomment-12099554>.
- ubuntu-22.04-arm
- macOS-13
- macOS-latest
test_group:
- core
- neural_networks
# - core
# - neural_networks
- integration
assertions:
- false
include:
- os: ubuntu-24.04
version: '1.10'
assertions: true
test_group: core
- os: ubuntu-24.04
version: '1.10'
assertions: true
test_group: neural_networks
- os: ubuntu-24.04
version: '1.10'
assertions: true
test_group: integration
# - os: ubuntu-24.04
# libReactant: packaged
# version: '1.10'
# test_group: core
# - os: ubuntu-24.04
# libReactant: packaged
# version: '1.10'
# test_group: neural_networks
# - os: ubuntu-24.04
# libReactant: packaged
# version: '1.10'
# test_group: integration
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
Expand Down Expand Up @@ -112,19 +82,10 @@ jobs:
if: ${{ matrix.version == '1.10' }}
env:
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
- name: "Run Tests"
timeout-minutes: 60
run: |
import Pkg
Pkg.Registry.update()
Pkg.test(; coverage="user")
shell: julia --color=yes --code-coverage=user --depwarn=yes --project=. {0}
id: run_tests
env:
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager
REACTANT_TEST_GROUP: ${{ matrix.test_group }}
XLA_FLAGS: "--xla_force_host_platform_device_count=8"
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v5
- name: Setup tmate session
uses: mxschmitt/action-tmate@v3
with:
files: lcov.info
limit-access-to-actor: false
# Debug with:
# julia --color=yes --code-coverage=user --depwarn=yes --check-bounds=yes --warn-overwrite=yes --inline=yes --startup-file=no --project=test -e 'using Pkg; Pkg.instantiate()'
# lldb -- julia --color=yes --code-coverage=user --depwarn=yes --check-bounds=yes --warn-overwrite=yes --inline=yes --startup-file=no --project=test test/integration/special_functions.jl
3 changes: 3 additions & 0 deletions LocalPreferences.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[Reactant_jll]
gpu = "none"
mode = "dbg"
3 changes: 3 additions & 0 deletions test/LocalPreferences.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[Reactant_jll]
gpu = "none"
mode = "dbg"
8 changes: 6 additions & 2 deletions test/Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ Optimisers = "3bd65402-5787-11e9-1adc-39752487f4e2"
PythonCall = "6099a3de-0909-46bc-b1f4-468b9a2dfc0d"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Random123 = "74087812-796a-5b5d-8853-05524746bad3"
Reactant = "3c362404-f566-11ee-1572-e11a4b42c853"
ReactantCore = "a3311ec8-5e00-46d5-b541-4f83e724a433"
Reactant_jll = "0192cb87-2b54-54ad-80e0-3be72ad8a3c0"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
Expand Down Expand Up @@ -62,5 +65,6 @@ StatsBase = "0.34"
Test = "1.10"
TestSetExtensions = "3"

[extras]
Reactant_jll = "0192cb87-2b54-54ad-80e0-3be72ad8a3c0"
[sources]
ReactantCore = {path = "../lib/ReactantCore"}
Reactant = {path = ".."}
1 change: 1 addition & 0 deletions test/integration/special_functions.jl
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using Test
using SpecialFunctions, Reactant

macro ≈(a, b)
Expand Down
56 changes: 28 additions & 28 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -43,40 +43,40 @@ const REACTANT_TEST_GROUP = lowercase(get(ENV, "REACTANT_TEST_GROUP", "all"))

@testset ExtendedTestSet "Reactant.jl Tests" begin
if REACTANT_TEST_GROUP == "all" || REACTANT_TEST_GROUP == "core"
@safetestset "Layout" include("layout.jl")
@safetestset "Tracing" include("tracing.jl")
# @safetestset "Layout" include("layout.jl")
# @safetestset "Tracing" include("tracing.jl")
@safetestset "Basic" include("basic.jl")
@safetestset "Autodiff" include("autodiff.jl")
@safetestset "Complex" include("complex.jl")
@safetestset "Broadcast" include("bcast.jl")
@safetestset "Struct" include("struct.jl")
@safetestset "Closure" include("closure.jl")
@safetestset "Compile" include("compile.jl")
@safetestset "Buffer Donation" include("buffer_donation.jl")
@safetestset "Shortcuts to MLIR ops" include("ops.jl")
@safetestset "Wrapped Arrays" include("wrapped_arrays.jl")
@safetestset "Control Flow" include("control_flow.jl")
@safetestset "Sorting" include("sorting.jl")
@safetestset "Indexing" include("indexing.jl")
if !Sys.isapple()
@safetestset "Custom Number Types" include("custom_number_types.jl")
end
@safetestset "Sharding" include("sharding.jl")
# @safetestset "Autodiff" include("autodiff.jl")
# @safetestset "Complex" include("complex.jl")
# @safetestset "Broadcast" include("bcast.jl")
# @safetestset "Struct" include("struct.jl")
# @safetestset "Closure" include("closure.jl")
# @safetestset "Compile" include("compile.jl")
# @safetestset "Buffer Donation" include("buffer_donation.jl")
# @safetestset "Shortcuts to MLIR ops" include("ops.jl")
# @safetestset "Wrapped Arrays" include("wrapped_arrays.jl")
# @safetestset "Control Flow" include("control_flow.jl")
# @safetestset "Sorting" include("sorting.jl")
# @safetestset "Indexing" include("indexing.jl")
# if !Sys.isapple()
# @safetestset "Custom Number Types" include("custom_number_types.jl")
# end
# @safetestset "Sharding" include("sharding.jl")

@testset "IFRT" begin
@safetestset "IFRT Low-Level API" include("ifrt/low_level.jl")
end
# @testset "IFRT" begin
# @safetestset "IFRT Low-Level API" include("ifrt/low_level.jl")
# end
end

if REACTANT_TEST_GROUP == "all" || REACTANT_TEST_GROUP == "integration"
@safetestset "CUDA" include("integration/cuda.jl")
@safetestset "KernelAbstractions" include("integration/kernelabstractions.jl")
@safetestset "Linear Algebra" include("integration/linear_algebra.jl")
@safetestset "OffsetArrays" include("integration/offsetarrays.jl")
@safetestset "AbstractFFTs" include("integration/fft.jl")
# @safetestset "CUDA" include("integration/cuda.jl")
# @safetestset "KernelAbstractions" include("integration/kernelabstractions.jl")
# @safetestset "Linear Algebra" include("integration/linear_algebra.jl")
# @safetestset "OffsetArrays" include("integration/offsetarrays.jl")
# @safetestset "AbstractFFTs" include("integration/fft.jl")
@safetestset "SpecialFunctions" include("integration/special_functions.jl")
@safetestset "Random" include("integration/random.jl")
@safetestset "Python" include("integration/python.jl")
# @safetestset "Random" include("integration/random.jl")
# @safetestset "Python" include("integration/python.jl")
end

if REACTANT_TEST_GROUP == "all" || REACTANT_TEST_GROUP == "neural_networks"
Expand Down