Support tracing of rem with only one operand being a ConcreteRNumber
#754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
Feb 16, 2025
They seemed to introduce several ambiguities.
giordano
changed the title
ConcreteRNumberrem with only one operand being a ConcreteRNumber
wsmoses
approved these changes
Feb 16, 2025
glwagner
added a commit
to glwagner/Reactant.jl
that referenced
this pull request
Feb 16, 2025
Captures EnzymeAD#754
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help with CliMA/Oceananigans.jl#4096 (comment).
Opening as a draft until I figure out where to test these new methods.Edit: tests added.