Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: the big jll PR #653

Merged
merged 6 commits into from
Jan 30, 2025
Merged

feat: the big jll PR #653

merged 6 commits into from
Jan 30, 2025

Conversation

avik-pal
Copy link
Collaborator

No description provided.

@avik-pal avik-pal requested review from wsmoses and giordano January 30, 2025 00:03
@avik-pal avik-pal marked this pull request as ready for review January 30, 2025 00:03
@giordano
Copy link
Member

To make review easier: this is combining changes in #637 and #647? Or is there something else?

@avik-pal
Copy link
Collaborator Author

that + https://github.com/EnzymeAD/Reactant.jl/pull/651/files#diff-7825e7cc90a3f97e7d676521e0edc4611097f618542a55d77f5ddc4380f7c5de

giordano
giordano reviewed Jan 30, 2025
View reviewed changes
deps/ReactantExtra/BUILD Outdated Show resolved Hide resolved
@avik-pal @giordano
Update deps/ReactantExtra/BUILD
7d1c031 
Co-authored-by: Mosè Giordano <[email protected]>
giordano
giordano approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as far as I can tell. I noticed you changed an argument to XLAExecute compared to #637, moving num_devices to inside the body of the function, but I presume you had your reasons to do that.

@avik-pal
Copy link
Collaborator Author

yes, this avoids a unnecessary breaking change in the API

giordano
giordano reviewed Jan 30, 2025
View reviewed changes
deps/ReactantExtra/BUILD Outdated Show resolved Hide resolved
@avik-pal @giordano
Update deps/ReactantExtra/BUILD
9336cfc 
Co-authored-by: Mosè Giordano <[email protected]>
@avik-pal avik-pal merged commit 5c67d0a into main Jan 30, 2025
28 of 32 checks passed
@avik-pal avik-pal deleted the ap/big_jll branch January 30, 2025 00:45
@giordano giordano mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano approved these changes

@wsmoses wsmoses Awaiting requested review from wsmoses

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avik-pal @giordano