-
Notifications
You must be signed in to change notification settings - Fork 21
ci: use self-hosted runners #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
if this works I will disable the buildkite runners for now |
c12e96c
to
ae6675a
Compare
1ab278a
to
530511c
Compare
clearly env vars were ignored... |
ok the runners are fully functional now! |
we really need to find and fix this |
That's simply hanging and the job is being terminated because it timed out. |
.github/workflows/CI.yml
Outdated
JULIA_PKG_SERVER_REGISTRY_PREFERENCE: eager | ||
ENABLE_PJRT_COMPATIBILITY: 1 | ||
REACTANT_TEST_GROUP: ${{ matrix.test_group }} | ||
XLA_FLAGS: "--xla_force_host_platform_device_count=12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need this? It wasn't set in the buildkite pipeline, as far as I can tell.
@@ -160,3 +160,86 @@ jobs: | |||
- uses: codecov/codecov-action@v5 | |||
with: | |||
files: lcov.info | |||
|
|||
test-cuda: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I'm not a huge fan or repeating the same workflow all over the place, a reusable workflow like what we have in the GB-25 repo would reduce duplication quite a lot. But this can be done in a followup, I guess now it's more important to make sure the workflow actually works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have create a common reusable workflow now
seems like XLA is being super slow for some reason |
Bus error on
|
No description provided.