Merge Develop to Release 0.22.5 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SRGDamia1, it's good to know that the code developments for this release (and possibly the previous 0.21.x releases) are not very likely to have messed with the Variable Array. I had thought that it might, given that it seemed we had similar issues with the GPRSBee modem variables. I make sense that those might be unrelated. I'll move all discussions of |
Additional conditions for a modem hard reset
aufdenkampe
changed the title
|
@SRGDamia1, have you been able to test this yet on the M0 boards? It would be great to release this! |
|
I'm going to work on this today. |
aufdenkampe
changed the title
aufdenkampe
commented
Jun 24, 2019
aufdenkampe
changed the title
|
I've tested the SAMD stuff and rolled in the timezone fix so lets get this pulled and released! |
|
I'll try to get to the release notes soon. |
|
@SRGDamia1, thank you! Once you do that, I'll also attend to the Zenodo stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this was developed in the modems branch and discussed and tested in #252 Radically simplified modems in sketches by making a modem parent class.
I think this is ready for prime time. What do you think @SRGDamia1, @fisherba and @neilh10?