Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag assign csp #581

Merged
merged 6 commits into from
Oct 8, 2024
Merged

feat: tag assign csp #581

merged 6 commits into from
Oct 8, 2024

Conversation

wai-wong-edb
Copy link
Collaborator

No description provided.

@wai-wong-edb wai-wong-edb force-pushed the ww-tag-csp branch 4 times, most recently from 28bc6ee to 4bf2250 Compare August 20, 2024 02:04
@wai-wong-edb wai-wong-edb changed the title feat: csp tags feat: tag assign csp Aug 22, 2024
@edbamolvyavahare
Copy link
Collaborator

at all places why are we referring as csp_tag_key and csp_tag_values,
? shouldn't they be rather :
csp_tag_key -> csp_tag_name
csp_tag_value -> csp_tag_color

Copy link
Collaborator

@edbamolvyavahare edbamolvyavahare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wai-wong-edb wai-wong-edb merged commit 4fa10a2 into main Oct 8, 2024
7 checks passed
@wai-wong-edb wai-wong-edb deleted the ww-tag-csp branch October 8, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants