feat: TDE for PG clusters #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 037c5ef)
# Conflicts: # examples/resources/biganimal_cluster/single_node/bah_aws/resource.tf # examples/resources/biganimal_cluster/single_node/bah_azure/resource.tf # examples/resources/biganimal_cluster/single_node/bah_gcp/resource.tf # examples/resources/biganimal_pgd/aws/bah_data_group/resource.tf # examples/resources/biganimal_pgd/aws/bah_data_groups_with_witness_group/resource.tf # examples/resources/biganimal_pgd/azure/bah_data_group/resource.tf # examples/resources/biganimal_pgd/azure/bah_data_groups_with_witness_group/resource.tf # examples/resources/biganimal_pgd/gcp/bah_data_group/resource.tf # examples/resources/biganimal_pgd/gcp/bah_data_groups_with_witness_group/resource.tf
…lica # Conflicts: # pkg/provider/provider.go
…ttributes # Conflicts: # pkg/provider/provider.go
# Conflicts: # examples/resources/biganimal_cluster/single_node/resource.tf # pkg/provider/resource_cluster.go
# Conflicts: # pkg/provider/resource_fareplica.go
wai-wong-edb
dismissed
vishalsawale9’s stale review
The base branch was changed.
# Conflicts: # examples/resources/biganimal_cluster/single_node/aws/resource.tf # examples/resources/biganimal_cluster/single_node/azure/resource.tf # examples/resources/biganimal_cluster/single_node/gcp/resource.tf # examples/resources/biganimal_cluster/single_node/resource.tf # pkg/provider/data_source_cluster.go # pkg/provider/resource_cluster.go
wai-wong-edb
force-pushed
the
ww-tde-pg-clusters
branch
from
b70eab6 to
3b1a96f
Compare
# Conflicts: # pkg/models/cluster.go
Comment on lines
+10
to
+18
| switch provider { | ||
| case "aws", "bah:aws": | ||
| return fmt.Sprintf(constants.TDE_KEY_AWS_ACTION, provider) | ||
| case "azure", "bah:azure": | ||
| return fmt.Sprintf(constants.TDE_KEY_AZURE_ACTION, provider) | ||
| case "gcp", "bah:gcp": | ||
| return fmt.Sprintf(constants.TDE_KEY_GCP_ACTION, provider) | ||
| default: | ||
| return fmt.Sprintf(constants.TDE_KEY_ACTION_UNKNOWN_PROVIDER_ERROR, provider) |
There was a problem hiding this comment.
- constants.TDE_KEY_AWS_ACTION message should be displayed for both BAH and BYOA providers
- exception: we do not support TDE for bah:azure yet
Suggested change
| switch provider { | |
| case "aws", "bah:aws": | |
| return fmt.Sprintf(constants.TDE_KEY_AWS_ACTION, provider) | |
| case "azure", "bah:azure": | |
| return fmt.Sprintf(constants.TDE_KEY_AZURE_ACTION, provider) | |
| case "gcp", "bah:gcp": | |
| return fmt.Sprintf(constants.TDE_KEY_GCP_ACTION, provider) | |
| default: | |
| return fmt.Sprintf(constants.TDE_KEY_ACTION_UNKNOWN_PROVIDER_ERROR, provider) | |
| switch provider { | |
| case "aws", "bah:aws": | |
| return fmt.Sprintf(constants.TDE_KEY_AWS_ACTION, provider) | |
| case "azure", "bah:azure": | |
| return fmt.Sprintf(constants.TDE_KEY_AZURE_ACTION, provider) | |
| case "gcp", "bah:gcp": | |
| return fmt.Sprintf(constants.TDE_KEY_GCP_ACTION, provider) | |
| default: | |
| return fmt.Sprintf(constants.TDE_KEY_ACTION_UNKNOWN_PROVIDER_ERROR, provider) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.