Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tag delete #521

Merged
merged 13 commits into from
Aug 14, 2024
Merged

feat: tag delete #521

merged 13 commits into from
Aug 14, 2024

Conversation

wai-wong-edb
Copy link
Collaborator

No description provided.

@wai-wong-edb wai-wong-edb changed the base branch from main to ww-tags-import April 2, 2024 12:21
@wai-wong-edb wai-wong-edb added the parked Parked label May 1, 2024
Copy link
Collaborator

@edbamolvyavahare edbamolvyavahare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from ww-tags-import to main August 13, 2024 12:16
@wai-wong-edb wai-wong-edb dismissed edbamolvyavahare’s stale review August 13, 2024 12:16

The base branch was changed.

# Conflicts:
#	examples/resources/biganimal_tag/resource.tf
#	pkg/api/tag_client.go
#	pkg/provider/provider.go
#	pkg/provider/resource_tag.go
Copy link
Collaborator

@edbamolvyavahare edbamolvyavahare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wai-wong-edb wai-wong-edb merged commit 0e10501 into main Aug 14, 2024
7 checks passed
@wai-wong-edb wai-wong-edb deleted the ww-tags-delete branch August 14, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parked Parked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants