Address Dependabot Upgrades #12013
Open
Address Dependabot Upgrades #12013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karla-vm
requested review from
JonHolman,
ntsummers1,
britt-mo,
gmrabian and
bangbay-bluetiger
karla-vm
requested review from
BearHanded,
braxex and
jessabean
as code owners
|
Code Climate has analyzed commit 915f941 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
JonHolman
reviewed
Jan 22, 2025
Closed
8 tasks
| @@ -48,8 +48,8 @@ | |||
| "kafkajs": "^2.2.3", | |||
| "ksuid": "^3.0.0", | |||
| "micromatch": "^4.0.8", | |||
| "nanoid": "^3.3.8", | |||
| "path-to-regexp": "^6.3.0", | |||
| "nanoid": "^3.3.7", | |||
There was a problem hiding this comment.
These packages can be removed from package.json. (Delete manually.)
| @@ -601,11 +601,6 @@ nanoid@^3.3.6: | |||
| resolved "https://registry.yarnpkg.com/nanoid/-/nanoid-3.3.6.tgz#443380c856d6e9f9824267d960b4236ad583ea4c" | |||
| integrity sha512-BGcqMMJuToF7i1rt+2PWSNVnWIkGCU78jBG3RxO/bZlnZPK2Cmi2QaffxGO/2RvWi9sL+FAiRiXMgsyxQ1DIDA== | |||
|
|
|||
| nanoid@^3.3.8: | |||
There was a problem hiding this comment.
nanoid can still be updated in this project: yarn upgrade nanoid@^3.3.6
| @@ -12,7 +12,7 @@ | |||
| "@aws-sdk/client-cognito-identity-provider": "^3.712.0", | |||
| "braces": "^3.0.3", | |||
| "micromatch": "^4.0.8", | |||
| "nanoid": "^3.3.8" | |||
| "nanoid": "^3.3.6" | |||
There was a problem hiding this comment.
Remove manually from the file.
| @@ -14,7 +14,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "cross-spawn": "^7.0.6", | |||
| "path-to-regexp": "^6.3.0", | |||
| "path-to-regexp": "^6.1.0", | |||
There was a problem hiding this comment.
Both path-to-regexp and ws can be removed from here.
| @@ -25,6 +25,6 @@ | |||
| }, | |||
| "dependencies": { | |||
| "cross-spawn": "^7.0.6", | |||
| "ws": "^7.5.10" | |||
| "ws": "^7.2.3" | |||
There was a problem hiding this comment.
Remove manually from file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually addressing the following
dependabotupgrades: #12007Related ticket(s)
N/A
How to test
N/A
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod