-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMDCT-4228: Address Pen Test Findings #12000
Merged
Merged
+54
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karla-vm
requested review from
JonHolman,
ntsummers1,
britt-mo,
gmrabian,
benmartin-coforma and
bangbay-bluetiger
January 9, 2025 15:38
karla-vm
requested review from
BearHanded,
braxex and
jessabean
as code owners
January 9, 2025 15:38
JonHolman
reviewed
Jan 9, 2025
Co-authored-by: Jon Holman <[email protected]>
JonHolman
previously approved these changes
Jan 9, 2025
gmrabian
previously approved these changes
Jan 9, 2025
8 tasks
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Code Climate has analyzed commit 017ee3c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
JonHolman
approved these changes
Jan 9, 2025
bangbay-bluetiger
approved these changes
Jan 9, 2025
benmartin-coforma
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CCIC penetration testing team was able to inject HTML into the
Admin Banner
form. @benmartin-coforma investigated a potential issue withDOMpurify
not cleaning up a string that was larger than 16KB and found a solution which is being addressed here.Related ticket(s)
CMDCT-4228
How to test
N/A
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod