Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use intercept to check for Launch Darkly flag #11962

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

bangbay-bluetiger
Copy link
Contributor

Description

  • Add a flag attribute to route
  • If it doesn't match a live Launch Darkly flag, the route is skipped in Cypress form test

Related ticket(s)


How to test

  1. yarn test should pass

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Copy link

codeclimate bot commented Dec 9, 2024

Code Climate has analyzed commit 2a64482 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@britt-mo britt-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed. Great solution for the flag checks. It's probably worth writing a spike card to look into how we can do the flag check with Launch Darkly SDK.

@bangbay-bluetiger bangbay-bluetiger merged commit 96c91b4 into main Dec 9, 2024
21 checks passed
@bangbay-bluetiger bangbay-bluetiger deleted the bs-intercept branch December 9, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants