-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmdct-4131 header playwright test #11961
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt-mo
requested review from
BearHanded,
braxex,
jessabean and
karla-vm
as code owners
December 6, 2024 21:47
karla-vm
previously approved these changes
Dec 9, 2024
gmrabian
previously approved these changes
Dec 9, 2024
gmrabian
previously approved these changes
Dec 9, 2024
JonHolman
previously approved these changes
Dec 9, 2024
bangbay-bluetiger
dismissed stale reviews from JonHolman and gmrabian
via
December 9, 2024 20:54
024f3e4
Code Climate has analyzed commit 13e105e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
bangbay-bluetiger
approved these changes
Dec 9, 2024
gmrabian
approved these changes
Dec 10, 2024
The logout test is failing in CI (we have it set to ignore failures right now so it looks like a pass) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Playwright test to replace header.cy
Related ticket(s)
CMDCT-4131
How to test
Make sure your .env is up-to-date - ./run update-env
Run yarn test:e2e or yarn test:e2e-ui
All tests should pass
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod