Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmdct-4131 header playwright test #11961

Merged
merged 5 commits into from
Dec 10, 2024
Merged

cmdct-4131 header playwright test #11961

merged 5 commits into from
Dec 10, 2024

Conversation

britt-mo
Copy link
Contributor

@britt-mo britt-mo commented Dec 6, 2024

Description

Playwright test to replace header.cy

Related ticket(s)

CMDCT-4131


How to test

  • Make sure your .env is up-to-date - ./run update-env

  • Run yarn test:e2e or yarn test:e2e-ui

  • All tests should pass

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

karla-vm
karla-vm previously approved these changes Dec 9, 2024
gmrabian
gmrabian previously approved these changes Dec 9, 2024
@britt-mo britt-mo dismissed stale reviews from gmrabian and karla-vm via fe3cbb0 December 9, 2024 18:24
gmrabian
gmrabian previously approved these changes Dec 9, 2024
JonHolman
JonHolman previously approved these changes Dec 9, 2024
@bangbay-bluetiger bangbay-bluetiger dismissed stale reviews from JonHolman and gmrabian via 024f3e4 December 9, 2024 20:54
Copy link

codeclimate bot commented Dec 9, 2024

Code Climate has analyzed commit 13e105e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@gmrabian
Copy link
Contributor

The logout test is failing in CI (we have it set to ignore failures right now so it looks like a pass)
It passes locally

@britt-mo britt-mo merged commit 73b3982 into main Dec 10, 2024
19 checks passed
@britt-mo britt-mo deleted the cmdct-4131 branch December 10, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants