Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMDCT-4116: NAAAR Dashboard Fields #11949

Merged
merged 2 commits into from
Dec 2, 2024
Merged

CMDCT-4116: NAAAR Dashboard Fields #11949

merged 2 commits into from
Dec 2, 2024

Conversation

karla-vm
Copy link
Collaborator

@karla-vm karla-vm commented Dec 2, 2024

Description

Currently, not all of the fields for the NAAAR report are populating the dashboard and this PR addresses that by adding the missing fields.

Related ticket(s)

CMDCT-4116


How to test

  • Log in as a state user
  • Create a new NAAAR report
  • Verify that all of the fields match the dashboard headers

Notes

N/A


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

britt-mo
britt-mo previously approved these changes Dec 2, 2024
Copy link
Contributor

@britt-mo britt-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard had all correct data under corresponding header fields

Copy link
Contributor

@bangbay-bluetiger bangbay-bluetiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking suggestion

Copy link

codeclimate bot commented Dec 2, 2024

Code Climate has analyzed commit 6dc4cb6 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@karla-vm karla-vm merged commit 6da73bd into main Dec 2, 2024
19 checks passed
@karla-vm karla-vm deleted the cmdct-4116 branch December 2, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants