Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add padding in between fields #11948

Merged
merged 1 commit into from
Dec 3, 2024
Merged

add padding in between fields #11948

merged 1 commit into from
Dec 3, 2024

Conversation

britt-mo
Copy link
Contributor

@britt-mo britt-mo commented Dec 2, 2024

Description

Padding was lost between fields:

Screenshot 2024-12-02 at 8 53 20 AM

Added top padding like so:

Screenshot 2024-12-02 at 8 53 08 AM

Related ticket(s)

bug found by Kim


How to test

Create a work plan, see that the dynamic fields have 2rem padding in between fields, no change to padding above the first field and below the last field.

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

Copy link

codeclimate bot commented Dec 2, 2024

Code Climate has analyzed commit 4304110 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

Copy link
Collaborator

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@britt-mo britt-mo merged commit f7ce769 into main Dec 3, 2024
21 checks passed
@britt-mo britt-mo deleted the dynamic-field-fix branch December 3, 2024 17:28
@britt-mo britt-mo restored the dynamic-field-fix branch December 3, 2024 18:05
britt-mo added a commit that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants