Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signout maybe #11931

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fix signout maybe #11931

merged 2 commits into from
Nov 18, 2024

Conversation

benmartin-coforma
Copy link
Contributor

@benmartin-coforma benmartin-coforma commented Nov 18, 2024

Description

Follow-up PR to #11929. That change affected what happens when the user clicks "Log Out"; this change should affect what happens on page load.

Related ServiceNow support ticket: CS2371782

Amplify documentation: https://docs.amplify.aws/react/build-a-backend/auth/connect-your-frontend/manage-user-sessions/#refreshing-sessions


How to test

  1. Log in via IDM for appropriate environment.
  2. When you are logged into the app, log out.
  3. After the redirect to IDM/Okta, log out of IDM.
  4. Enter the url for the app. YOU SHOULD NOT BE ALREADY AUTHENTICATED.

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

@benmartin-coforma benmartin-coforma marked this pull request as ready for review November 18, 2024 21:27
@jessabean jessabean merged commit 94cb7de into main Nov 18, 2024
13 checks passed
@jessabean jessabean deleted the fix-signout-maybe branch November 18, 2024 21:27
jessabean added a commit that referenced this pull request Nov 18, 2024
jessabean added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants