Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmdct 4125 - refactor report page footer #11930

Merged
merged 24 commits into from
Nov 20, 2024
Merged

Cmdct 4125 - refactor report page footer #11930

merged 24 commits into from
Nov 20, 2024

Conversation

britt-mo
Copy link
Contributor

Description

Refactored report page footer to be more like that of MFP. Logic for previous and the two kinds of continue buttons are in their own variables and called from inside the return statement. Also simplified styling.

Related ticket(s)

CMDCT-4125


How to test

compare any environment (local, dev, val, etc) to the cloudfront link and see there shouldn't be any difference in the UI of the report page footer.

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

britt-mo added 22 commits July 16, 2024 13:39
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small requests!

This reminded me as well that we want to have the bar separating the report questions from the footer as part of the footer as well. I will make a ticket for that!
Screenshot 2024-11-19 at 9 28 10 AM

gmrabian
gmrabian previously approved these changes Nov 19, 2024
services/ui-src/src/constants.ts Outdated Show resolved Hide resolved
@britt-mo britt-mo merged commit 0e056be into main Nov 20, 2024
17 checks passed
@britt-mo britt-mo deleted the cmdct-4125 branch November 20, 2024 16:00
@britt-mo britt-mo restored the cmdct-4125 branch November 20, 2024 22:03
britt-mo added a commit that referenced this pull request Nov 20, 2024
@britt-mo britt-mo deleted the cmdct-4125 branch November 21, 2024 00:36
@bangbay-bluetiger bangbay-bluetiger mentioned this pull request Nov 22, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants