Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright setup #11927

Merged
merged 9 commits into from
Nov 21, 2024
Merged

Playwright setup #11927

merged 9 commits into from
Nov 21, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Nov 15, 2024

Description

Most of this is copied from MFP, with minor changes for repository naming and organization

  • Add new env variables for playwright
    • these use the same cypress credentials for now, but sets us up to swap them later if need be
  • Add cron job to remove old playwright reports from gh-pages branch
    • Add rm_old_folders.py script for cron job
  • Add playwright tests and report upload to deploy workflow
  • Add playwright dependencies in test package
  • Add playwright config and base setup and tests from MFP
    • These are almost unchanged from MFP, with a few changes to update expected headings

Related ticket(s)

CMDCT-4127


How to test

  • View the deploy workflow for this branch
    • Verify it runs playwright tests after cypress
    • Verify it won't delist the github actions cidrs until tests are done
    • Verify it uploads reports by viewing the github pages link provided in the summary

Pull branch and run playwright tests locally
cd tests/ && yarn
playwright install browsers
yarn test:e2e-ui

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

@gmrabian gmrabian marked this pull request as ready for review November 18, 2024 16:08
@gmrabian gmrabian added the ready for review Ready for all the reviews! label Nov 18, 2024
Copy link
Contributor

@bangbay-bluetiger bangbay-bluetiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/playwright/utils/pageObjects/base.page.ts Outdated Show resolved Hide resolved
@gmrabian gmrabian merged commit 93656be into main Nov 21, 2024
19 checks passed
@gmrabian gmrabian deleted the playwright-setup branch November 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants