Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify apiRequest call #11923

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Simplify apiRequest call #11923

merged 3 commits into from
Nov 14, 2024

Conversation

bangbay-bluetiger
Copy link
Contributor

@bangbay-bluetiger bangbay-bluetiger commented Nov 13, 2024

Description

Refactor to match the pattern in Enterprise-CMCS/macpro-mdct-mfp#801.

Related ticket(s)

CMDCT-4037


How to test

  • Everything in the app works as expected. A short list of everything:
    • all api calls
    • auth
    • timeout
    • template file download
  • Automated tests pass

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Copy link

codeclimate bot commented Nov 13, 2024

Code Climate has analyzed commit 67906bb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@bangbay-bluetiger bangbay-bluetiger merged commit 4102b76 into main Nov 14, 2024
19 checks passed
@bangbay-bluetiger bangbay-bluetiger deleted the amplify-followup branch November 14, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants