-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add plans page in naaar #11921
add plans page in naaar #11921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me! Tested in the deployed instance.
Nit:
I've always hated this pages spacing between the dynamic fields and text describing the page. What if we tightened this up a little?
Could overwrite the dynamicField and textField css props we have in the DynamicField.tsx file with something like this:
dynamicField: {
alignItems: "flex-end",
marginTop: "1.5rem",
".desktop &": {
width: "32rem",
},
".tablet &": {
width: "29rem",
},
".ds-u-clearfix": {
width: "100%",
},
},
textField: {
width: "100%",
label: {
marginTop: "0",
},
},
The key things I changed being the marginTop gets moved to the dynamic field css and we overwrite the label in the textfield from having the marginTop by making it 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re: your question, I believe plans are going to be an entity going forward, so I would keep it as part of this PR. We'll be needing to have some discussions around the data structure of NAAAR soon 💯
c92b04e
@ntsummers1 I added the changes and noticed the |
Code Climate has analyzed commit 8d1a844 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Description
Add the "Add Plans" page to the naaar report. Copied from mcpar with some verbiage and metadata updates.
Notes/Questions: Do we need to add plans to the entities object? I did but I'm not exactly sure where/how it is used
Related ticket(s)
CMDCT-4098
How to test
Pre-review checklist
[ ] I have added thorough tests, if necessary[ ] I have updated relevant documentation, if necessaryPre-merge checklist
Review