Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plans page in naaar #11921

Merged
merged 3 commits into from
Nov 14, 2024
Merged

add plans page in naaar #11921

merged 3 commits into from
Nov 14, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Nov 13, 2024

Description

Add the "Add Plans" page to the naaar report. Copied from mcpar with some verbiage and metadata updates.

Notes/Questions: Do we need to add plans to the entities object? I did but I'm not exactly sure where/how it is used

Related ticket(s)

CMDCT-4098


How to test

  • Run app or view deployed branch
  • Log in as any state user
  • Create a NAAAR
  • Enter the NAAAR and verify there is an add plans page
  • Verify you can add and remove plans
  • Verify it matches the figma design

Pre-review checklist

  • [ ] I have added thorough tests, if necessary
  • [ ] I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

@gmrabian gmrabian marked this pull request as ready for review November 13, 2024 14:55
@gmrabian gmrabian added the ready for review Ready for all the reviews! label Nov 13, 2024
Copy link
Contributor

@bangbay-bluetiger bangbay-bluetiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked for me.

ntsummers1
ntsummers1 previously approved these changes Nov 13, 2024
Copy link
Contributor

@ntsummers1 ntsummers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me! Tested in the deployed instance.

Nit:
I've always hated this pages spacing between the dynamic fields and text describing the page. What if we tightened this up a little?
Could overwrite the dynamicField and textField css props we have in the DynamicField.tsx file with something like this:

dynamicField: {
    alignItems: "flex-end",
    marginTop: "1.5rem",
    ".desktop &": {
      width: "32rem",
    },
    ".tablet &": {
      width: "29rem",
    },
    ".ds-u-clearfix": {
      width: "100%",
    },
  },
  textField: {
    width: "100%",

    label: {
      marginTop: "0",
    },
  },

The key things I changed being the marginTop gets moved to the dynamic field css and we overwrite the label in the textfield from having the marginTop by making it 0.

karla-vm
karla-vm previously approved these changes Nov 13, 2024
Copy link
Collaborator

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re: your question, I believe plans are going to be an entity going forward, so I would keep it as part of this PR. We'll be needing to have some discussions around the data structure of NAAAR soon 💯

@gmrabian
Copy link
Contributor Author

@ntsummers1 I added the changes and noticed the marginTop in dynamicField didn't affect anything so I just added the label prop

@gmrabian gmrabian enabled auto-merge (squash) November 14, 2024 17:28
Copy link

codeclimate bot commented Nov 14, 2024

Code Climate has analyzed commit 8d1a844 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian merged commit 4cf9bb6 into main Nov 14, 2024
17 checks passed
@gmrabian gmrabian deleted the naaar-add-plans branch November 14, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants