-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable NAAAR creation on backend #11911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change related to update made in my PR, but I can also make the change in my PR after merge.
Co-authored-by: Bangbay Siboliban <[email protected]>
Code Climate has analyzed commit 8df61dc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Description
NAAAR infrastructure is already in place. We just need to remove some code-level checks that were blocking creation.
The NAAAR dashboard page is behind a flag so you can only get to this flow when it is enabled
Related ticket(s)
CMDCT-4095
How to test
To test case when feature flag is disabled:
naaarReport
variable fromuseFlags
to false and verify the creation flow errors with a 400Notes
I had to make some updates to the frontend flow and add fields to the naaar report json. It makes testing this more logical but still leaves the remainder of the work open for other teammates :)
Pre-review checklist
Pre-merge checklist
Review