Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoy uat 233 #11496

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Yoy uat 233 #11496

merged 3 commits into from
Oct 18, 2023

Conversation

benmartin-coforma
Copy link
Contributor

Description

This PR contains only text changes, per the feedback we received from UAT.

Related ticket(s)

CMDCT-233


How to test

  1. Go to the MCPAR dashboard - verify that the call to action is correct
  2. Create a new MCPAR report - verify that the verbiage in the modal is correct
  3. Enter that report - verify that the affected questions' verbiage is all correct

Important updates

n/a


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • [] I have updated relevant documentation, if necessary

@codeclimate
Copy link

codeclimate bot commented Oct 18, 2023

Code Climate has analyzed commit 5a95bcf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.9%.

View more on Code Climate.

gmrabian
gmrabian previously approved these changes Oct 18, 2023
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified locally

karla-vm
karla-vm previously approved these changes Oct 18, 2023
@benmartin-coforma benmartin-coforma dismissed stale reviews from karla-vm and gmrabian via 3c85f84 October 18, 2023 18:36
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silly verbiage based tests

@benmartin-coforma benmartin-coforma merged commit 0481d89 into main Oct 18, 2023
13 checks passed
@benmartin-coforma benmartin-coforma deleted the yoy-uat-233 branch October 18, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants