Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): Fix lint warnings #944

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

fix(meta): Fix lint warnings #944

wants to merge 16 commits into from

Conversation

tbolt
Copy link
Collaborator

@tbolt tbolt commented Dec 18, 2024

💬 Description / Notes

This PR attempts to remediate all of the lint warnings. All of the lint warnings are from the rule react-hooks/exhaustive-deps.

The general strategy for these fixes were

  1. Attempt to follow the lint advice. This means where appropriate add the missing value from the dependency array.
  2. If the above couldn't be done, usually from it causing an infinite loop, attempt to refactor the code.
  3. If neither of the above could be done, then add the ignore-rule for the specific line only.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.19% 7860 / 8912
🔵 Statements 87.32% 8250 / 9447
🔵 Functions 81.14% 2337 / 2880
🔵 Branches 57.18% 1612 / 2819
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react-app/src/components/Opensearch/main/useOpensearch.ts 16.66% 0% 0% 16.66% 47-76, 79-136, 140-154
react-app/src/components/Opensearch/main/Filtering/Drawer/hooks.ts 2.7% 0% 0% 3.07% 13-67, 71-178
react-app/src/components/RHF/Slot.tsx 100% 91.66% 100% 100%
react-app/src/components/RHF/dependencyWrapper.tsx 58.92% 50% 72.72% 60.78% 7, 16, 21-46, 80-93, 100
react-app/src/components/SearchForm/index.tsx 100% 100% 100% 100%
react-app/src/features/package/admin-changes/index.tsx 33.33% 0% 0% 37.5% 54-65, 87-90
react-app/src/hooks/UseMediaQuery.test.tsx 100% 100% 100% 100%
react-app/src/hooks/useMediaQuery.ts 100% 100% 100% 100%
react-app/src/hooks/useIdle/index.ts 95.23% 50% 88.88% 94.73% 44
Generated in workflow #1552 for commit 7b4a5ec by the Vitest Coverage Report Action

@tbolt tbolt temporarily deployed to fix-lint-warnings January 2, 2025 14:54 — with GitHub Actions Inactive
@tbolt tbolt had a problem deploying to fix-lint-warnings January 2, 2025 14:54 — with GitHub Actions Failure
@tbolt tbolt temporarily deployed to fix-lint-warnings January 2, 2025 14:57 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 2, 2025 14:57 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-app January 2, 2025 14:57 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-kibana January 2, 2025 14:57 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 2, 2025 14:57 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 7, 2025 16:15 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 7, 2025 16:15 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-kibana January 7, 2025 16:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-app January 7, 2025 16:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 7, 2025 16:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 7, 2025 16:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 7, 2025 16:19 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 9, 2025 14:18 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 9, 2025 14:18 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-app January 9, 2025 14:23 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 9, 2025 14:23 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 9, 2025 14:23 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-kibana January 9, 2025 14:23 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 9, 2025 14:23 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 13, 2025 15:51 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 13, 2025 15:51 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 13, 2025 15:55 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-app January 13, 2025 15:55 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 13, 2025 15:55 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-kibana January 13, 2025 15:55 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 13, 2025 15:55 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 15, 2025 19:49 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 15, 2025 19:49 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 15, 2025 19:54 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 15, 2025 19:54 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-app January 15, 2025 19:54 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings-kibana January 15, 2025 19:54 — with GitHub Actions Inactive
@tbolt tbolt temporarily deployed to fix-lint-warnings January 15, 2025 19:54 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant