Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(align-statuses): Align Statuses in Upgrade (MAKO) with Legacy (OneMAC) #927

Merged
merged 47 commits into from
Jan 15, 2025
Merged

feat(align-statuses): Align Statuses in Upgrade (MAKO) with Legacy (OneMAC) #927

merged 47 commits into from
Jan 15, 2025

Conversation

13bfrancis
Copy link
Collaborator

@13bfrancis 13bfrancis commented Dec 12, 2024 •
edited
Loading

🎫 Linked Ticket

https://jiraent.cms.gov/browse/OY2-31121

💬 Description / Notes

The purpose of this PR is to attempt to align the status that exist in the legacy OneMAC system with our system. Per my research I found the statuses in the onemac system to align with what is below:

Status Research

——— Medicaid SPA and All Waivers ————

Medicaid SPA and All Waivers: New Submission

  • CMS Status: Submitted - Intake Needed
    • Available Actions:
      • None
  • State Status: Submitted
    • Available Actions:
      • None
        Medicaid SPA and All Waivers: Complete Intake In SeaTool
  • CMS Status: Pending
    • Available Actions:
      • None
  • State Status: Under Review
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
        Medicaid SPA and All Waivers: Issue RAI in Seatool
  • CMS Status: Pending - RAI
    • Available Actions:
      • None
  • State Status: RAI Issued
    • Available Actions:
      • Withdraw Package
      • Respond to RAI
        Medicaid SPA and All Waivers: Respond to RAI in OneMAC
  • CMS Status: Submitted - Intake Needed
    • Available Actions:
      • None
  • State Status: Submitted
    • Available Actions:
      • None
        Medicaid SPA and All Waivers: Respond to RAI in SeaTool
  • CMS Status: Pending / Second Clock
    • Available Actions:
      • Enable Formal RAI Response Withdraw
  • State Status: Under Review
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
        Medicaid SPA and All Waivers: Enable RAI Response Withdraw in OneMAC
  • CMS Status: Pending / Second Clock / Withdraw Formal RAI Response Enabled
    • Available Actions:
      • Disable Formal RAI Response Withdraw
  • State Status: Under Review / Withdraw Formal RAI Response Enabled
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
      • Withdraw Formal RAI Response
        Medicaid SPA and All Waivers: Withdraw Formal RAI Response in OneMAC
  • CMS Status: Formal RAI Response - Withdrawal Requested
    • Available Actions:
      • None
  • State Status: Formal RAI Response - Withdrawal Requested
    • Available Actions:
      • None
        Medicaid SPA and All Waivers: Withdraw Formal RAI Response in SeaTool
  • CMS Status: Pending
    • Available Actions:
      • None
  • State Status: Under Review
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
        Medicaid SPA and All Waivers: Upload Subsequent Documents in OneMAC
  • CMS Status: Pending
    • Available Actions:
      • None
  • State Status: Under Review
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
        Medicaid SPA and All Waivers: Withdraw Package in OneMAC
  • CMS Status: Submitted - Intake Needed
    • Available Actions:
      • None
  • State Status: Withdrawal Requested
    • Available Actions:
      • None
        Medicaid SPA and All Waivers: Withdraw Package in SeaTool
  • CMS Status: Package Withdrawn
    • Available Actions:
      • None
  • State Status: Package Withdrawn
    • Available Actions:
      • None

———— CHIP SPA ————

CHIP SPA: New Submission

  • CMS Status: Submitted - Intake Needed
    • Available Actions:
      • None
  • State Status: Submitted
    • Available Actions:
      • None
        CHIP SPA: Complete Intake In SeaTool
  • CMS Status: Pending
    • Available Actions:
      • None
  • State Status: Under Review
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
        CHIP SPA: Issue RAI in Seatool
  • CMS Status: Pending - RAI
    • Available Actions:
      • None
  • State Status: RAI Issued
    • Available Actions:
      • Withdraw Package
      • Respond to RAI
        CHIP SPA: Respond to RAI in OneMAC
  • CMS Status: Submitted - Intake Needed
    • Available Actions:
      • None
  • State Status: Submitted
    • Available Actions:
      • None
        CHIP SPA: Respond to RAI in SeaTool
  • CMS Status: Pending
    • Available Actions:
      • Enable Formal RAI Response Withdraw
  • State Status: Under Review
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
        CHIP SPA: Enable RAI Response Withdraw in OneMAC
  • CMS Status: Pending / Withdraw Formal RAI Response Enabled
    • Available Actions:
      • Disable Formal RAI Response Withdraw
  • State Status: Under Review / Withdraw Formal RAI Response Enabled
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
      • Withdraw Formal RAI Response
        CHIP SPA: Withdraw Formal RAI Response in OneMAC
  • CMS Status: Formal RAI Response - Withdrawal Requested
    • Available Actions:
      • None
  • State Status: Formal RAI Response - Withdrawal Requested
    • Available Actions:
      • None
        CHIP SPA: Withdraw Formal RAI Response in SeaTool
  • CMS Status: Pending
    • Available Actions:
      • None
  • State Status: Under Review
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
        CHIP SPA: Upload Subsequent Documents in OneMAC
  • CMS Status: Pending
    • Available Actions:
      • None
  • State Status: Under Review
    • Available Actions:
      • Withdraw Package
      • Upload Subsequent Documents
        CHIP SPA: Withdraw Package in OneMAC
  • CMS Status: Submitted - Intake Needed
    • Available Actions:
      • None
  • State Status: Withdrawal Requested
    • Available Actions:
      • None
        CHIP SPA: Withdraw Package in SeaTool
  • CMS Status: Package Withdrawn
    • Available Actions:
      • None
  • State Status: Package Withdrawn
    • Available Actions:
      • None

———— Temporary Extension 1915(b) and 1915(c) ————

Temp Extension: New Submission

  • CMS Status: Requested
    • Available Actions:
      • None
  • State Status: Submitted
    • Available Actions:
      • None

🛠 Changes

Basically what needed to be done is a few new statuses needed to be created to represent gaps in our current implementation of statuses, and also some of our current statuses needed to change to properly align with the list above.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 86.37% 7712 / 8928
🔵 Statements 85.66% 8084 / 9437
🔵 Functions 80.09% 2294 / 2864
🔵 Branches 55.81% 1573 / 2818
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
lib/lambda/sinkMainProcessors.test.ts 100% 100% 100% 100%
lib/packages/shared-types/statusHelper.ts 100% 100% 50% 100%
lib/packages/shared-types/opensearch/main/transforms/app-k.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/capitated-amendment.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/capitated-initial.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/capitated-renewal.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/contracting-amendment.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/contracting-initial.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/contracting-renewal.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/new-chip-submission.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/new-medicaid-submission.ts 100% 100% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/respond-to-rai.ts 100% 50% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/seatool.ts 76.81% 62.03% 75.86% 80.35% 46-55, 59, 62, 65, 109, 47-55, 109
lib/packages/shared-types/opensearch/main/transforms/withdraw-package.ts 100% 50% 75% 100%
lib/packages/shared-types/opensearch/main/transforms/withdraw-rai-response.ts 100% 50% 75% 100%
lib/packages/shared-utils/package-check.ts 100% 100% 100% 100%
lib/packages/shared-utils/package-actions/rules.ts 78.37% 27.67% 86.66% 76.47% 56-64, 119, 123, 127, 131, 135-139
react-app/src/components/Opensearch/main/Filtering/Drawer/consts.ts 100% 100% 100% 100%
react-app/src/features/dashboard/Lists/spas/consts.tsx 2.77% 0% 0% 3.03% 10-145
react-app/src/features/dashboard/Lists/waivers/consts.tsx 2.5% 0% 0% 2.77% 10-156
react-app/src/features/forms/post-submission/respond-to-rai/index.tsx 70% 50% 50% 70% 23, 58, 91
react-app/src/features/forms/post-submission/withdraw-package/index.tsx 38.46% 0% 33.33% 38.46% 7-43, 97, 145
react-app/src/features/forms/post-submission/withdraw-rai/index.tsx 100% 33.33% 100% 100%
react-app/src/features/package/admin-changes/index.tsx 33.33% 0% 0% 37.5% 54-65, 86-89
react-app/src/features/package/package-activity/index.test.tsx 100% 100% 100% 100%
react-app/src/features/package/package-activity/index.tsx 94.28% 89.47% 100% 94.28% 160, 167
react-app/src/features/package/package-status/index.tsx 14.28% 0% 0% 16.66% 7-28
Generated in workflow #1520 for commit 84b035a by the Vitest Coverage Report Action

@13bfrancis 13bfrancis temporarily deployed to status-parity-kibana December 16, 2024 14:23 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to status-parity-kibana December 16, 2024 18:07 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to status-parity-kibana December 16, 2024 18:16 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to status-parity-app January 15, 2025 19:02 — with GitHub Actions Inactive
@13bfrancis 13bfrancis temporarily deployed to status-parity-kibana January 15, 2025 19:02 — with GitHub Actions Inactive
thetif
thetif approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@13bfrancis 13bfrancis merged commit d647fc8 into main Jan 15, 2025
15 checks passed
@13bfrancis 13bfrancis deleted the status-parity branch January 15, 2025 19:35
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.5.0-val.108 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asharonbaltazar asharonbaltazar asharonbaltazar left review comments

@tiffanyvu tiffanyvu tiffanyvu approved these changes

@thetif thetif thetif approved these changes

Assignees
No one assigned
Labels
released on @val
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@13bfrancis @thetif @asharonbaltazar @tiffanyvu @benjaminpaige