-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(package-actions): remove withdraw rai writes from seatool #800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit bbb5c14 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 40.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.6% (-0.6% change). View more on Code Climate. |
Closing due to code being merged to #824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We are in the process of removing writes to SEA Tool.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-29922
Approach
This issue focuses on refactoring the withdraw RAI form to use a more testable, reusable component to be uniform with all package actions. Zod schemas have been refined.
Assorted Notes/Considerations/Learning
There is one line in the component that needs to be unit tested to reach adequate code coverage and may be more involved than we previously expected. Since other components will need to test for the same line, that effort will be continued to be worked on throughout the following sprints.