feat(emails): New Implementation of sending emails w/ cdk and w/o without templates #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminpaige
added
In Testing
benjaminpaige
temporarily deployed
to
brain-kibana
GitHub Actions
Inactive
benjaminpaige
temporarily deployed
to
brain-app
GitHub Actions
Inactive
|
Code Climate has analyzed commit 036e874 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 40.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.4% (-0.7% change). View more on Code Climate. |
benjaminpaige
temporarily deployed
to
brain-kibana
GitHub Actions
Inactive
andieswift
temporarily deployed
to
brain-dev-email
GitHub Actions
Inactive
andieswift
temporarily deployed
to
brain-dev-email
GitHub Actions
Inactive
andieswift
had a problem deploying
to
brain-dev-email
GitHub Actions
Failure
andieswift
temporarily deployed
to
brain-dev-email
GitHub Actions
Inactive
andieswift
temporarily deployed
to
brain-dev-email
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In this version of Onemac we do not keep a User Table so we rely on cognito and seatoool for our recipients. This nversion adds functinality to get allState submitters when needed as well as cpoc and srt emails and names and adding them to the correct emails when needed. Also, we are removing the templates for numerous reasons and replacing with the use of React.email library. Which makes it easier to use, cheeper, gives it proper email html content.... etc.
Linked Issues to Close
This should close :
Assorted Notes/Considerations/Learning
This relies on emailAddresses that are secrets but also gets info from seatool (cpoc, srt's) and all state users via ListUsers from cognito. But this does not account for users that sign up but never sign in. Which we are hopefully going to have a solution from IDM asap.
Andie's Notes
The email templates are created with React Email
To test the emails in dev
npm run email-devChanges to the components will need to be refreshed to see