Playwright build out #741
Merged
Playwright build out #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out-app
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out-kibana
GitHub Actions
Inactive
zerogravit1
had a problem deploying
to
pw-build-out
GitHub Actions
Failure
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
benjaminpaige
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
I love this! especially the Page classses. It feels so much cleaner, and adding the dta tags.... 100% percent on board with that. This really looks like things are going well and good patterns are being tryed and established.
Before you go to far, there was some talk about Breaking out this app into a different app (one that would not live under the "react-app" directory. This has some benefits and tradeoffs but if you thik it might be woth diwscussing, lmk.
test/e2e/pages/loginPage.ts
Outdated
Comment on lines
17
to
19
| // expect( | ||
| await this.page.getByRole("link", { name: "Dashboard" }).isVisible(); | ||
| // ).toBeTruthy(); |
There was a problem hiding this comment.
Was this comment forgotten?
test/e2e/playwright.config.ts
Outdated
| @@ -18,7 +18,7 @@ const baseURL = process.env.STAGE_NAME | |||
| ).applicationEndpointUrl | |||
| : "http://localhost:5000"; | |||
|
|
|||
| console.log(`Playwright configured to run against ${baseURL}`); | |||
| // console.log(`Playwright configured to run against ${baseURL}`); | |||
test/e2e/utils/auth.setup.ts
Outdated
There was a problem hiding this comment.
And the comments on this page as well
zerogravit1
force-pushed
the
pw-build-out
branch
from
13ef22b to
5c95703
Compare
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
zerogravit1
had a problem deploying
to
pw-build-out
GitHub Actions
Failure
zerogravit1
temporarily deployed
to
pw-build-out-kibana
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out-app
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out-app
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out-kibana
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
Add tests to validate banner Fix broken test Update tests - change reporter to dot, more CI friendly Resolve comments Resolve issues - remove used variable - updated selector to reduce flakiness
zerogravit1
force-pushed
the
pw-build-out
branch
from
9fd3639 to
0156790
Compare
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
|
Code Climate has analyzed commit 0156790 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.7% (0.0% change). View more on Code Climate. |
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
zerogravit1
temporarily deployed
to
pw-build-out
GitHub Actions
Inactive
|
🎉 This PR is included in version 1.5.0-val.79 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Describe the problem or feature in addition to a link to the issues.
Linked Issues to Close
Links to issue(s) that are closed by this PR. Be sure to use the phrase "Closes #XXX" for each issue, so they automatically close
Approach
How does this change address the issue?
Assorted Notes/Considerations/Learning
List any other information that you think is important... a post-merge activity, someone to notify, what you learned, etc.