feat(disable export button): Disable export button when no records available #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
asharonbaltazar
approved these changes
Aug 30, 2024
react-app/src/components/Opensearch/main/Filtering/Export/Export.test.tsx
Outdated
Show resolved
Hide resolved
react-app/src/components/Opensearch/main/Filtering/Export/index.tsx
Outdated
Show resolved
Hide resolved
…ven if button is enabled
tiffanyvu
temporarily deployed
to
tiffany-kibana
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
tiffany-app
GitHub Actions
Inactive
tiffanyvu
temporarily deployed
to
tiffany-kibana
GitHub Actions
Inactive
|
Code Climate has analyzed commit 12c5ed0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 90.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.7% (0.1% change). View more on Code Climate. |
tiffanyvu
changed the title
tiffanyvu
changed the title
|
🎉 This PR is included in version 1.5.0-val.77 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When there are no records to display in the Dashboard page, the "Export" button is falsely enabled. If a user tries to export the records, the button infinitely loads and it is not obvious there is an error.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-28648?atlOrigin=eyJpIjoiYmZkOTIxMDg2YmYwNDgxN2E5Y2E4OWFjNmFiZDE4MjQiLCJwIjoiaiJ9
Approach
To replicate this error there should be no records available or simply typing an invalid field in the search bar that will return no records. The "Export" button will now be disabled and if hovered, a tooltip will appear telling users there are no records available to export.
Assorted Notes/Considerations/Learning
When writing the unit tests for this component, I ran into an issue while trying to render the OsExportData component stating that a function within the file (useOsUrl) was not a function. This was due to me using the automatic import VSCode suggested for the component instead of importing it with "@/". The function inside the component is imported by the "@/" syntax.
Screen.Recording.2024-08-29.at.2.13.57.PM.mov