fix(g2 divider fix): fix divider issues on g2a and g2b #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdinh8124
requested review from
daniel-belcher,
charmcitygavin and
benjaminpaige
Coverage Report
File CoverageNo changed files found. |
jdinh8124
temporarily deployed
to
g2-divider-app
GitHub Actions
Inactive
jdinh8124
temporarily deployed
to
g2-divider-kibana
GitHub Actions
Inactive
jdinh8124
temporarily deployed
to
g2-divider-app
GitHub Actions
Inactive
jdinh8124
temporarily deployed
to
g2-divider-kibana
GitHub Actions
Inactive
jdinh8124
temporarily deployed
to
g2-divider-app
GitHub Actions
Inactive
jdinh8124
temporarily deployed
to
g2-divider-kibana
GitHub Actions
Inactive
charmcitygavin
approved these changes
Aug 23, 2024
|
Code Climate has analyzed commit fb17aae and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.4% (0.0% change). View more on Code Climate. |
benjaminpaige
approved these changes
Sep 4, 2024
|
🎉 This PR is included in version 1.5.0-val.76 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There was an issue where a few dividers were missing on g2a and g2b. We added logic to include these divider bars in sections that the figma required.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-29463