feat(ui): userPrompt
#713
Merged
feat(ui): userPrompt
#713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return userPromptState.create(newuserPrompt); | ||
| }; | ||
|
|
||
| export const UserPrompt = () => { |
There was a problem hiding this comment.
Function UserPrompt has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
asharonbaltazar
temporarily deployed
to
userprompt
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
userprompt
GitHub Actions
Inactive
|
Code Climate has analyzed commit 9ba4c3d and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.7% (0.3% change). View more on Code Climate. |
asharonbaltazar
temporarily deployed
to
userprompt
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
userprompt
GitHub Actions
Inactive
asharonbaltazar
temporarily deployed
to
userprompt
GitHub Actions
Inactive
13bfrancis
reviewed
Aug 7, 2024
|
@13bfrancis since they'll be both tied to the same So two dialogs, but the same content. |
13bfrancis
approved these changes
Aug 7, 2024
|
🎉 This PR is included in version 1.5.0-val.71 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To prepare the codebase for the eventual forms revamp and lay the ground for best test practices, I'm making the transition easier by removing our reliance on React-centric logic.
ModalContextrelied on two things: aProviderand React's rules of hooks, both limiting what we can do when it comes to defining user prompts.Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-29584
Approach
We needed to ditch
Provider. After some research and experimentation, I think using an observer pattern is the best bet. Sure, it requires some setup, but the advantage is now we can create auserPromptfrom anywhere in the code, regardless of where it's defined. This also means we can testuserPromptand spy on whether it's called, just like any function, and thus reducing the complexity for our tests without the setup that context and hooks require.data-testidattributes toDialogfor testingConfirmationModaltoConfirmationDialogto better reflect its childrenConfirmationDialoginto its own folderuserPrompt